diff --git a/d2oracle/edit.go b/d2oracle/edit.go index 075959e78..d5b0896c1 100644 --- a/d2oracle/edit.go +++ b/d2oracle/edit.go @@ -110,7 +110,7 @@ func ReconnectEdge(g *d2graph.Graph, edgeKey string, srcKey, dstKey *string) (_ } if srcKey == nil && dstKey == nil { - return nil, errors.New("must provide at least one new endpoint") + return g, nil } var src *d2graph.Object @@ -1893,7 +1893,7 @@ func ReconnectEdgeIDDeltas(g *d2graph.Graph, edgeKey string, srcKey, dstKey *str } if srcKey == nil && dstKey == nil { - return nil, errors.New("must provide at least one new endpoint") + return nil, nil } newSrc := edge.Src diff --git a/d2oracle/edit_test.go b/d2oracle/edit_test.go index 05ef1f877..6c5c4a070 100644 --- a/d2oracle/edit_test.go +++ b/d2oracle/edit_test.go @@ -1768,21 +1768,6 @@ x newDst: "x", expErr: "newDst not found", }, - { - name: "missing_params", - text: `a -> b -`, - edgeKey: `(a -> b)[0]`, - expErr: "must provide at least one new endpoint", - }, - { - name: "bad_params", - text: `a -> b -`, - edgeKey: `(a -> b)[0]`, - newDst: "b", - expErr: "must provide at least one new endpoint", - }, } for _, tc := range testCases { diff --git a/testdata/d2oracle/TestReconnectEdge/bad_params.exp.json b/testdata/d2oracle/TestReconnectEdge/bad_params.exp.json deleted file mode 100644 index f933a6875..000000000 --- a/testdata/d2oracle/TestReconnectEdge/bad_params.exp.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "graph": null, - "err": "&errors.errorString{s:\"must provide at least one new endpoint\"}" -} diff --git a/testdata/d2oracle/TestReconnectEdge/missing_params.exp.json b/testdata/d2oracle/TestReconnectEdge/missing_params.exp.json deleted file mode 100644 index f933a6875..000000000 --- a/testdata/d2oracle/TestReconnectEdge/missing_params.exp.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "graph": null, - "err": "&errors.errorString{s:\"must provide at least one new endpoint\"}" -}