From e44ac23c84dd8e486a0483ecfef02f6b303a7364 Mon Sep 17 00:00:00 2001 From: Gavin Nishizawa Date: Wed, 20 Sep 2023 11:51:43 -0700 Subject: [PATCH] cleanup warning --- d2layouts/d2grid/layout.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/d2layouts/d2grid/layout.go b/d2layouts/d2grid/layout.go index ae917d28e..9e9109453 100644 --- a/d2layouts/d2grid/layout.go +++ b/d2layouts/d2grid/layout.go @@ -704,20 +704,14 @@ func (gd *gridDiagram) getBestLayout(targetSize float64, columns bool) [][]*d2gr // if multiple nodes are too big, it isn't ok. but a single node can't shrink so only check here if rowSize > okThreshold*targetSize { skipCount++ - if skipCount >= SKIP_LIMIT { - // there may even be too many to skip - return true - } - return false + // there may even be too many to skip + return skipCount >= SKIP_LIMIT } } // row is too small to be good overall if rowSize < targetSize/okThreshold { skipCount++ - if skipCount >= SKIP_LIMIT { - return true - } - return false + return skipCount >= SKIP_LIMIT } return true }