luciano/diff2html
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use operator assignement and remove redundant else

Browse source
This commit is contained in:
Rodrigo Fernandes 2016-05-20 23:25:10 +01:00
parent 285c3fefc5
commit ce90977163
No known key found for this signature in database
GPG key ID: 08E3C5F38969078E
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/printer-utils.js
View file

@ -54,7 +54,7 @@
while (i < j && i < k) { while (i < j && i < k) {
if (oldFilenameParts[i] === newFilenameParts[i]) { if (oldFilenameParts[i] === newFilenameParts[i]) {
prefixPaths.push(newFilenameParts[i]); prefixPaths.push(newFilenameParts[i]);
i = i + 1; i += 1;
} else { } else {
break; break;
} }
@ -63,8 +63,8 @@
while (j > i && k > i) { while (j > i && k > i) {
if (oldFilenameParts[j] === newFilenameParts[k]) { if (oldFilenameParts[j] === newFilenameParts[k]) {
suffixPaths.unshift(newFilenameParts[k]); suffixPaths.unshift(newFilenameParts[k]);
j = j - 1; j -= 1;
k = k - 1; k -= 1;
} else { } else {
break; break;
} }
@ -82,10 +82,10 @@
return finalPrefix + separator + '{' + oldRemainingPath + ' → ' + newRemainingPath + '}'; return finalPrefix + separator + '{' + oldRemainingPath + ' → ' + newRemainingPath + '}';
} else if (finalSuffix.length) { } else if (finalSuffix.length) {
return '{' + oldRemainingPath + ' → ' + newRemainingPath + '}' + separator + finalSuffix; return '{' + oldRemainingPath + ' → ' + newRemainingPath + '}' + separator + finalSuffix;
} else {
return oldFilename + ' → ' + newFilename;
} }
return oldFilename + ' → ' + newFilename;
} else if (newFilename && !isDevNullName(newFilename)) { } else if (newFilename && !isDevNullName(newFilename)) {
return newFilename; return newFilename;
} else if (oldFilename) { } else if (oldFilename) {
@ -180,9 +180,9 @@
function unifyPath(path) { function unifyPath(path) {
if (path) { if (path) {
return path.replace('\\', '/'); return path.replace('\\', '/');
} else {
return path;
} }
return path;
} }
function isDevNullName(name) { function isDevNullName(name) {