From 316b88233419a31d1cee2afa32c7db06a278dccf Mon Sep 17 00:00:00 2001 From: Andrea Richiardi Date: Mon, 24 Sep 2018 22:23:40 -0700 Subject: [PATCH] Add mimimal test for #288 --- test/honeysql/core_test.cljc | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/test/honeysql/core_test.cljc b/test/honeysql/core_test.cljc index 2c3ceb6..09637cf 100644 --- a/test/honeysql/core_test.cljc +++ b/test/honeysql/core_test.cljc @@ -6,7 +6,7 @@ [honeysql.helpers :refer [select modifiers from join left-join right-join full-join where group having order-by limit offset values columns - insert-into with]] + insert-into with merge-where]] honeysql.format-test)) ;; TODO: more tests @@ -215,4 +215,30 @@ (where [:= :id (sql/inline nil)]) sql/format)))) +(deftest merge-where-no-params-test + (testing "merge-where called with empty vector parameter - see #288" + (is (= ["SELECT * FROM table WHERE foo = bar"] + (-> (select :*) + (from :table) + (where [:= :foo :bar]) + (merge-where []) + sql/format))))) + +(deftest merge-where-nil-params-test + (testing "merge-where called with nil as parameter - see #288" + (is (= ["SELECT * FROM table WHERE foo = bar"] + (-> (select :*) + (from :table) + (where [:= :foo :bar]) + (merge-where nil) + sql/format))))) + +(deftest merge-where-test + (is (= ["SELECT * FROM table WHERE (foo = bar AND quuz = xyzzy)"] + (-> (select :*) + (from :table) + (where [:= :foo :bar]) + (merge-where [:= :quuz :xyzzy]) + sql/format)))) + #?(:cljs (cljs.test/run-all-tests))