From 4fbf69e59ea20cca73a46e05749d675cc760d108 Mon Sep 17 00:00:00 2001 From: Sean Corfield Date: Sat, 7 Sep 2019 13:14:36 -0700 Subject: [PATCH] Fixes #99 by clarifying column names in the readme --- CHANGES.md | 1 + README.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index cd54f65..349c73f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,6 +1,7 @@ ## Changes coming in 0.9.7 * Fix #248 by treating alias as "not a subquery" when generating SQL for it. (@seancorfield) +* Fix #99 by adding a note to the first use of `select` in the README that column names can be keywords or symbols but not strings. ## 0.9.6 diff --git a/README.md b/README.md index 3adc0f7..0abd54b 100644 --- a/README.md +++ b/README.md @@ -37,6 +37,8 @@ Everything is built on top of maps representing SQL queries: :where [:= :f.a "baz"]}) ``` +Column names can be provided as keywords or symbols (but not strings -- HoneySQL treats strings as values that should be lifted out of the SQL as parameters). + `format` turns maps into `clojure.java.jdbc`-compatible, parameterized SQL: ```clojure