From 803584dc7c4310c5ab16b097aa2536e391ed2262 Mon Sep 17 00:00:00 2001 From: Oleksandr Yakushev Date: Fri, 27 Sep 2024 09:58:54 +0300 Subject: [PATCH] More efficient check for suspicious entities re-find sets up the regex machinery which is unnecessary here. str/includes? of a single character is more efficient. --- src/honey/sql.cljc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/honey/sql.cljc b/src/honey/sql.cljc index ad9c24e..c390feb 100644 --- a/src/honey/sql.cljc +++ b/src/honey/sql.cljc @@ -161,8 +161,8 @@ (def ^:no-doc ^:dynamic *escape-?* true) ;; suspicious entity names: -(def ^:private suspicious #";") -(defn- suspicious? [s] (boolean (re-find suspicious s))) +(def ^:private suspicious ";") +(defn- suspicious? [s] (str/includes? s suspicious)) (defn- suspicious-entity-check [entity] (when-not *allow-suspicious-entities* (when (suspicious? entity)