From ac136dab08f1725eab564be03b83145c23ea5b25 Mon Sep 17 00:00:00 2001 From: Oleksandr Yakushev Date: Fri, 27 Sep 2024 09:58:01 +0300 Subject: [PATCH] Pass strings to strop Converting Character->String involves additional allocations. Passing literal strings avoids that. --- src/honey/sql.cljc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/honey/sql.cljc b/src/honey/sql.cljc index b9c0f53..ad9c24e 100644 --- a/src/honey/sql.cljc +++ b/src/honey/sql.cljc @@ -110,16 +110,16 @@ (reduce-kv (fn [m k v] (assoc m k (assoc v :dialect k))) {} - {:ansi {:quote #(strop \" % \")} - :sqlserver {:quote #(strop \[ % \])} - :mysql {:quote #(strop \` % \`) + {:ansi {:quote #(strop "\"" % "\"")} + :sqlserver {:quote #(strop "[" % "]")} + :mysql {:quote #(strop "`" % "`") :clause-order-fn #(add-clause-before % :set :where)} - :nrql {:quote #(strop \` % \`) + :nrql {:quote #(strop "`" % "`") :col-fn #(if (keyword? %) (subs (str %) 1) (str %)) :parts-fn vector} - :oracle {:quote #(strop \" % \") :as false} - :xtdb {:quote #(strop \" % \") + :oracle {:quote #(strop "\"" % "\"") :as false} + :xtdb {:quote #(strop "\"" % "\"") :col-fn #(if (keyword? %) (subs (str %) 1) (str %)) :parts-fn #(str/split % #"\.")}})))