Merge pull request #78 from dball/fix-parameterizable-for-nil

Fix the parameterizable protocol to include nil

CHANGES.md

@@ -1,5 +1,7 @@
 ## 0.6.1 In development
 
+* Define parameterizable protocol on nil (@dball)
+
 ## 0.6.0
 
 * Convert seq param values to literal sql param lists (@dball)

src/honeysql/format.clj

@@ -258,6 +258,11 @@
   clojure.lang.IPersistentSet
   (to-params [value pname]
     (to-params (seq value) pname))
+  nil
+  (to-params [value pname]
+    (swap! *params* conj value)
+    (swap! *param-names* conj pname)
+    (*parameterizer*))
   java.lang.Object
   (to-params [value pname]
     (swap! *params* conj value)

test/honeysql/core_test.clj

@@ -82,6 +82,17 @@
            sql/format))))
 
 (deftest test-operators
+  (testing "="
+    (testing "with nil"
+      (is (= ["SELECT * FROM customers WHERE name IS NULL"]
+             (sql/format {:select [:*]
+                          :from [:customers]
+                          :where [:= :name nil]})))
+      (is (= ["SELECT * FROM customers WHERE name = ?" nil]
+             (sql/format {:select [:*]
+                          :from [:customers]
+                          :where [:= :name :?name]}
+                         {:name nil})))))
   (testing "in"
     (doseq [[cname coll] [[:vector []] [:set #{}] [:list '()]]]
       (testing (str "with values from a " (name cname))