luciano/honeysql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

placeholder (should :array unwrap params?)

Browse source
This commit is contained in:
Sean Corfield 2022-05-20 10:34:10 -07:00
parent 5fe73c75bc
commit d065a04e18
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/honey/sql.cljc
View file

@ -1235,6 +1235,7 @@
">")]) ">")])
:array :array
(fn [_ [arr]] (fn [_ [arr]]
;; allow for (unwrap arr) here?
(let [[sqls params] (format-expr-list arr)] (let [[sqls params] (format-expr-list arr)]
(into [(str "ARRAY[" (str/join ", " sqls) "]")] params))) (into [(str "ARRAY[" (str/join ", " sqls) "]")] params)))
:between :between

8
test/honey/sql_test.cljc
View file

@ -207,7 +207,13 @@
(is (= (format {:insert-into :foo (is (= (format {:insert-into :foo
:columns [:baz] :columns [:baz]
:values [[[:array ["one" "two" "three"]]]]}) :values [[[:array ["one" "two" "three"]]]]})
["INSERT INTO foo (baz) VALUES (ARRAY[?, ?, ?])" "one" "two" "three"]))) ["INSERT INTO foo (baz) VALUES (ARRAY[?, ?, ?])" "one" "two" "three"]))
#_ ;; requested feature -- does not work yet
(is (= (format {:insert-into :foo
:columns [:baz]
:values [[[:array :?vals]]]}
{:params {:vals [1 2 3 4]}})
["INSERT INTO foo (baz) VALUES (ARRAY[?, ?, ?, ?])" 1 2 3 4])))
(deftest union-test (deftest union-test
;; UNION and INTERSECT subexpressions should not be parenthesized. ;; UNION and INTERSECT subexpressions should not be parenthesized.