luciano/honeysql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor format-values to do fewer allocations

Browse source
This commit is contained in:
Oleksandr Yakushev 2025-01-08 17:55:21 +02:00
parent 3ecac63bea
commit d086631e54
2 changed files with 31 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -1,7 +1,7 @@
# Changes
* 2.6.next in progress
* More performance optimizations via PR [#560](https://github.com/seancorfield/honeysql/pull/560) [@alexander-yakushev](https://github.com/alexander-yakushev).
* More performance optimizations via PRs [#560](https://github.com/seancorfield/honeysql/pull/560) and [#562](https://github.com/seancorfield/honeysql/pull/562) [@alexander-yakushev](https://github.com/alexander-yakushev).
* Fix two broken links to the [HoneySQL web app](https://john.shaffe.rs/honeysql/) via PR [#559](https://github.com/seancorfield/honeysql/pull/559) [@whatacold](https://github.com/whatacold).
* Make SQL Server dialect auto-lift Boolean values to parameters since SQL Server has no `TRUE` / `FALSE` literals.

60
src/honey/sql.cljc
View file

@ -1177,17 +1177,17 @@
x))
xs)))
[sqls params]
(reduce (fn [[sql params] [sqls' params']]
[(conj sql
(if (sequential? sqls')
(str "(" (join ", " sqls') ")")
sqls'))
(into params params')])
(reduce (fn [[sql params] x]
(if (sequential? x)
(let [[sqls' params'] (format-expr-list x)]
[(conj sql
(if (sequential? sqls')
(str "(" (join ", " sqls') ")")
sqls'))
(into* params params')])
[(conj sql (sql-kw x)) params]))
[[] []]
(map #(if (sequential? %)
(format-expr-list %)
[(sql-kw %)])
xs'))
xs')
sqls (if row-ctr (map #(str "ROW" %) sqls) sqls)]
(into [(str (sql-kw k) " " (join ", " sqls))] params))
@ -1199,26 +1199,26 @@
(contains-clause? :replace-into)
(contains-clause? :columns)))
[sqls params]
(reduce (fn [[sql params] [sqls' params']]
[(conj sql
(if (sequential? sqls')
(str "(" (join ", " sqls') ")")
sqls'))
(if params' (into params params') params')])
[[] []]
(map (fn [m]
(if (map? m)
(format-expr-list
(map #(get m
%
;; issue #366: use NULL or DEFAULT
;; for missing column values:
(if (contains? *values-default-columns* %)
[:default]
nil))
cols))
[(sql-kw m)]))
xs))]
(reduce
(fn [[sql params] x]
(if (map? x)
(let [[sqls' params']
(reduce-sql (map #(format-expr
(get x %
;; issue #366: use NULL or DEFAULT
;; for missing column values:
(if (contains? *values-default-columns* %)
[:default]
nil))))
cols)]
[(conj sql
(if (sequential? sqls')
(str "(" (join ", " sqls') ")")
sqls'))
(into* params params')])
[(conj sql (sql-kw x)) params]))
[[] []]
xs)]
(into [(str (when cols-sql
(str cols-sql " "))
(sql-kw k)