change the l4g.Critical, os.Exit combo to log.Fatal, because l4g defers output so the critical logs are not being seen

This commit is contained in:
dan 2015-04-04 10:24:23 -07:00
parent 852cf2a7d2
commit 18163c1599
3 changed files with 10 additions and 16 deletions

View file

@ -1,8 +1,8 @@
package connector
import (
"log"
"math"
"os"
"time"
"github.com/ezoic/go-kinesis"
@ -62,8 +62,7 @@ func (p Pipeline) ProcessShard(ksis *kinesis.Kinesis, shardID string) {
shardInfo, err := ksis.GetShardIterator(args)
if err != nil {
l4g.Critical("GetShardIterator ERROR: %v", err)
os.Exit(1)
log.Fatalf("GetShardIterator ERROR: %v\n", err)
}
shardIterator := shardInfo.ShardIterator
@ -85,8 +84,7 @@ func (p Pipeline) ProcessShard(ksis *kinesis.Kinesis, shardID string) {
consecutiveErrorAttempts++
continue
} else {
l4g.Critical("GetRecords ERROR: %v\n", err)
os.Exit(1)
log.Fatalf("GetRecords ERROR: %v\n", err)
}
} else {
consecutiveErrorAttempts = 0

View file

@ -4,6 +4,7 @@ import (
"bytes"
"database/sql"
"fmt"
"log"
"os"
// Postgres package is used when sql.Open is called
@ -31,15 +32,13 @@ func (e RedshiftBasicEmtitter) Emit(b Buffer, t Transformer) {
db, err := sql.Open("postgres", os.Getenv("REDSHIFT_URL"))
if err != nil {
l4g.Critical(err)
os.Exit(1)
log.Fatal(err)
}
_, err = db.Exec(e.copyStatement(s3File))
if err != nil {
l4g.Critical(err)
os.Exit(1)
log.Fatal(err)
}
l4g.Debug("Redshift load completed.")

View file

@ -5,6 +5,7 @@ import (
"database/sql"
"encoding/json"
"fmt"
"log"
"os"
"strings"
"time"
@ -35,9 +36,7 @@ func (e RedshiftManifestEmitter) Emit(b Buffer, t Transformer) {
db, err := sql.Open("postgres", os.Getenv("REDSHIFT_URL"))
if err != nil {
l4g.Critical(err)
os.Exit(1)
log.Fatal(err)
}
// Aggregate file paths as strings
@ -57,8 +56,7 @@ func (e RedshiftManifestEmitter) Emit(b Buffer, t Transformer) {
_, err = db.Exec(c)
if err != nil {
l4g.Critical(err)
os.Exit(1)
log.Fatal(err)
}
// Insert file paths into File Names table
@ -66,8 +64,7 @@ func (e RedshiftManifestEmitter) Emit(b Buffer, t Transformer) {
_, err = db.Exec(i)
if err != nil {
l4g.Critical(err)
os.Exit(1)
log.Fatal(err)
}
l4g.Info("[%v] copied to Redshift", manifestFileName)