Add option for immediate rescan
When immediate rescan is enabled, a poll from Kinesis that returns records and also indicates we are still behind the latest record will skip waiting for the next scan interval and rescan immediately. Related, the initial scan for a shard is performed immediately. The scan ticker only applies to subsequent scans. These changes make higher scan intervals feasible, allowing for less chatty clients while also improving overall effective throughput.
This commit is contained in:
parent
3f2519e51c
commit
3372ea1d17
2 changed files with 16 additions and 2 deletions
10
consumer.go
10
consumer.go
|
|
@ -39,8 +39,9 @@ func New(streamName string, opts ...Option) (*Consumer, error) {
|
|||
logger: &noopLogger{
|
||||
logger: log.New(ioutil.Discard, "", log.LstdFlags),
|
||||
},
|
||||
scanInterval: 250 * time.Millisecond,
|
||||
maxRecords: 10000,
|
||||
scanInterval: 250 * time.Millisecond,
|
||||
immediateRescan: false,
|
||||
maxRecords: 10000,
|
||||
}
|
||||
|
||||
// override defaults
|
||||
|
|
@ -76,6 +77,7 @@ type Consumer struct {
|
|||
logger Logger
|
||||
store Store
|
||||
scanInterval time.Duration
|
||||
immediateRescan bool
|
||||
maxRecords int64
|
||||
}
|
||||
|
||||
|
|
@ -206,6 +208,10 @@ func (c *Consumer) ScanShard(ctx context.Context, shardID string, fn ScanFunc) e
|
|||
}
|
||||
|
||||
shardIterator = resp.NextShardIterator
|
||||
if c.immediateRescan && len(resp.Records) > 0 && *resp.MillisBehindLatest > 0 {
|
||||
// There appears to be additional records, so skip waiting for next tick
|
||||
continue
|
||||
}
|
||||
}
|
||||
|
||||
// Wait for next scan
|
||||
|
|
|
|||
|
|
@ -65,6 +65,14 @@ func WithScanInterval(d time.Duration) Option {
|
|||
}
|
||||
}
|
||||
|
||||
// WithImmediateRescan overrides whether we wait for the next
|
||||
// scan interval if records were fetched during a poll
|
||||
func WithImmediateRescan(r bool) Option {
|
||||
return func(c *Consumer) {
|
||||
c.immediateRescan = r
|
||||
}
|
||||
}
|
||||
|
||||
// WithMaxRecords overrides the maximum number of records to be
|
||||
// returned in a single GetRecords call for the consumer (specify a
|
||||
// value of up to 10,000)
|
||||
|
|
|
|||
Loading…
Reference in a new issue