Use ID over Id from Golang best practices

This commit is contained in:
Harlow Ward 2014-07-28 16:33:42 -07:00
parent 57dc74bd48
commit f7d1202fe0

View file

@ -9,7 +9,7 @@ import (
type Checkpoint interface { type Checkpoint interface {
CheckpointExists(streamName string, shardID string) bool CheckpointExists(streamName string, shardID string) bool
SequenceNumber() string SequenceNumber() string
SetCheckpoint(streamName string, shardId string, sequenceNumber string) SetCheckpoint(streamName string, shardID string, sequenceNumber string)
} }
type RedisCheckpoint struct { type RedisCheckpoint struct {
@ -22,8 +22,8 @@ func (c RedisCheckpoint) SequenceNumber() string {
return c.sequenceNumber return c.sequenceNumber
} }
func (c *RedisCheckpoint) CheckpointExists(streamName string, shardId string) bool { func (c *RedisCheckpoint) CheckpointExists(streamName string, shardID string) bool {
key := c.keyGen(streamName, shardId) key := c.keyGen(streamName, shardID)
val, _ := c.client.Get(key) val, _ := c.client.Get(key)
if val != nil { if val != nil {
@ -34,12 +34,12 @@ func (c *RedisCheckpoint) CheckpointExists(streamName string, shardId string) bo
} }
} }
func (c *RedisCheckpoint) SetCheckpoint(streamName string, shardId string, sequenceNumber string) { func (c *RedisCheckpoint) SetCheckpoint(streamName string, shardID string, sequenceNumber string) {
key := c.keyGen(streamName, shardId) key := c.keyGen(streamName, shardID)
c.client.Set(key, []byte(sequenceNumber)) c.client.Set(key, []byte(sequenceNumber))
c.sequenceNumber = sequenceNumber c.sequenceNumber = sequenceNumber
} }
func (c RedisCheckpoint) keyGen(streamName string, shardId string) string { func (c RedisCheckpoint) keyGen(streamName string, shardID string) string {
return fmt.Sprintf("%v:checkpoint:%v:%v", c.appName, streamName, shardId) return fmt.Sprintf("%v:checkpoint:%v:%v", c.appName, streamName, shardID)
} }