luciano/markitdown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: update devcontainer configuration for clarity

Browse source 
Remove unnecessary INSTALL_GIT argument and set target to 
development in the devcontainer.json file. This simplifies 
the configuration and aligns it with the intended development 
environment setup.
This commit is contained in:
lumin 2024-12-21 11:52:21 +09:00 committed by GitButler
parent 5b811fd66a
commit 4050de78b6
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
.devcontainer/devcontainer.json
View file

@ -7,9 +7,7 @@
"context": "..", "context": "..",
// Update the 'dockerFile' property if you aren't using the standard 'Dockerfile' filename. // Update the 'dockerFile' property if you aren't using the standard 'Dockerfile' filename.
"dockerfile": "../Dockerfile", "dockerfile": "../Dockerfile",
"args": { "target": "development"
"INSTALL_GIT": "true"
}
}, },
// Features to add to the dev container. More info: https://containers.dev/features. // Features to add to the dev container. More info: https://containers.dev/features.
@ -17,6 +15,14 @@
"features": { "features": {
"ghcr.io/devcontainers-extra/features/hatch:2": {} "ghcr.io/devcontainers-extra/features/hatch:2": {}
}, },
"customizations": {
"vscode": {
"extensions": [
"ms-python.python",
"charliermarsh.ruff"
]
}
},
// Use 'forwardPorts' to make a list of ports inside the container available locally. // Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [], // "forwardPorts": [],
@ -28,5 +34,5 @@
// "customizations": {}, // "customizations": {},
// Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root. // Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root.
"remoteUser": "root" // "remoteUser": "root"
} }