luciano/next-jdbc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixes #293

Browse source 
Signed-off-by: Sean Corfield <sean@corfield.org>
This commit is contained in:
Sean Corfield 2025-01-28 10:11:25 -08:00
parent fa6f9040d7
commit 1294e35b98
No known key found for this signature in database
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -3,6 +3,7 @@
Only accretive/fixative changes will be made from now on. Only accretive/fixative changes will be made from now on.
* 1.3.next in progress * 1.3.next in progress
* Fix [#293](https://github.com/seancorfield/next-jdbc/issues/293) by no longer `locking` on the `Connection` retrieved from a `DataSource`.
* Fix documentation examples of `execute-batch!` via PR [#292](https://github.com/seancorfield/next-jdbc/pull/292) from [@devurandom](https://github.com/devurandom). * Fix documentation examples of `execute-batch!` via PR [#292](https://github.com/seancorfield/next-jdbc/pull/292) from [@devurandom](https://github.com/devurandom).
* Update `java.data` to 1.3.113. * Update `java.data` to 1.3.113.
* Beef up bit/boolean tests and enable them for XTDB. * Beef up bit/boolean tests and enable them for XTDB.

6
src/next/jdbc/transaction.clj
View file

@ -145,7 +145,11 @@
javax.sql.DataSource javax.sql.DataSource
(-transact [this body-fn opts] (-transact [this body-fn opts]
(with-open [con (p/get-connection this opts)] (with-open [con (p/get-connection this opts)]
(p/-transact con body-fn opts))) ;; this connection is assumed unique so we do not need the active-tx check:
(let [raw (raw-connection con)]
;; we don't lock either, per #293:
(binding [*active-tx* (conj *active-tx* raw)]
(transact* con body-fn opts)))))
Object Object
(-transact [this body-fn opts] (-transact [this body-fn opts]
(p/-transact (p/get-datasource this) body-fn opts))) (p/-transact (p/get-datasource this) body-fn opts)))