luciano/next-jdbc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix potential reflection warnings from use of next.jdbc.prepare/statement

Browse source
This commit is contained in:
Sean Corfield 2020-06-07 10:02:20 -07:00
parent 509e065fbf
commit 4045e18f3e
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -5,6 +5,7 @@ Only accretive/fixative changes will be made from now on.
Changes made on master since 1.0.462: Changes made on master since 1.0.462:
* Add tests for `"jtds"` database driver (against MS SQL Server), making it officially supported. * Add tests for `"jtds"` database driver (against MS SQL Server), making it officially supported.
* Switch from OpenTable Embedded PostgreSQL to Zonky's version, so that testing can move forward from PostgreSQL 10.11 to 12.2.0. * Switch from OpenTable Embedded PostgreSQL to Zonky's version, so that testing can move forward from PostgreSQL 10.11 to 12.2.0.
* Fix potential reflection warnings caused by `next.jdbc.prepare/statement` being incorrectly type-hinted.
* Address #119 by clarifying realization actions in the docstrings for `row-number`, `column-names`, and `metadata`. * Address #119 by clarifying realization actions in the docstrings for `row-number`, `column-names`, and `metadata`.
* Address #115 by adding equivalent of `db-do-commands` in the `clojure.java.jdbc` migration guide. * Address #115 by adding equivalent of `db-do-commands` in the `clojure.java.jdbc` migration guide.
* Add log4j2 as a test dependency so that I have better control over logging (which makes debugging easier!). * Add log4j2 as a test dependency so that I have better control over logging (which makes debugging easier!).

7
src/next/jdbc/prepare.clj
View file

@ -149,9 +149,10 @@
(defn statement (defn statement
"Given a `Connection` and some options, return a `Statement`." "Given a `Connection` and some options, return a `Statement`."
^java.sql.Statement (^java.sql.Statement
([con] (statement con {})) [con] (statement con {}))
([^Connection con (^java.sql.Statement
[^Connection con
{:keys [result-type concurrency cursors {:keys [result-type concurrency cursors
fetch-size max-rows timeout] fetch-size max-rows timeout]
:as opts}] :as opts}]