From 73a7b2af1048e9c19bf593c683fca29c51e4a5d9 Mon Sep 17 00:00:00 2001 From: Sean Corfield Date: Thu, 10 Jan 2019 18:24:55 -0800 Subject: [PATCH] Note: broken transaction machinery After removing records and relying entirely on protocols, transaction handling is broken because you can't `assoc` into a non-map. --- src/next/jdbc.clj | 1 + 1 file changed, 1 insertion(+) diff --git a/src/next/jdbc.clj b/src/next/jdbc.clj index f778df2..1f1650f 100644 --- a/src/next/jdbc.clj +++ b/src/next/jdbc.clj @@ -93,6 +93,7 @@ ;; should check isolation level; maybe implement save points? (f con) (with-open [^AutoCloseable t-con (assoc (get-connection con) + ;; FIXME: not a record/map! :transacted (atom committable?))] (let [^Connection jdbc t-con old-autocommit (.getAutoCommit jdbc)