luciano/next-jdbc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize by removing destructuring

Browse source
This commit is contained in:
Sean Corfield 2019-01-26 02:05:25 -08:00
parent 19ae37b3fe
commit 93eb286bd0
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/next/jdbc.clj
View file

@ -42,7 +42,7 @@
(-execute ^clojure.lang.IReduceInit [this sql-params opts])) (-execute ^clojure.lang.IReduceInit [this sql-params opts]))
(defprotocol Preparable (defprotocol Preparable
(prepare ^PreparedStatement [this sql-params opts]) (prepare ^PreparedStatement [this sql-params opts])
(prepare-fn ^PreparedStatement [this sql-params factory])) (prepare-fn ^PreparedStatement [this sql params factory]))
(defn execute! (defn execute!
"General SQL execution function. "General SQL execution function.
@ -156,7 +156,7 @@
(defn- prepare-fn* (defn- prepare-fn*
"Given a connection, a SQL statement, its parameters, and some options, "Given a connection, a SQL statement, its parameters, and some options,
return a PreparedStatement representing that." return a PreparedStatement representing that."
[con [sql & params] factory] [con sql params factory]
(set-parameters (factory con sql) params)) (set-parameters (factory con sql) params))
(def ^:private isolation-levels (def ^:private isolation-levels
@ -400,18 +400,18 @@
Connection Connection
(prepare [this sql-params opts] (prepare [this sql-params opts]
(prepare* this sql-params opts)) (prepare* this sql-params opts))
(prepare-fn [this sql-params factory] (prepare-fn [this sql params factory]
(prepare-fn* this sql-params factory)) (prepare-fn* this sql params factory))
DataSource DataSource
(prepare [this sql-params opts] (prepare [this sql-params opts]
(prepare (.getConnection this) sql-params opts)) (prepare (.getConnection this) sql-params opts))
(prepare-fn [this sql-params factory] (prepare-fn [this sql params factory]
(prepare-fn (.getConnection this) sql-params factory)) (prepare-fn (.getConnection this) sql params factory))
Object Object
(prepare [this sql-params opts] (prepare [this sql-params opts]
(prepare (get-datasource this) sql-params opts)) (prepare (get-datasource this) sql-params opts))
(prepare-fn [this sql-params factory] (prepare-fn [this sql params factory]
(prepare-fn (get-datasource this) sql-params factory))) (prepare-fn (get-datasource this) sql params factory)))
(defn- get-column-names (defn- get-column-names
"" ""
@ -489,19 +489,19 @@
(extend-protocol Executable (extend-protocol Executable
Connection Connection
(-execute [this sql-params opts] (-execute [this [sql & params] opts]
(let [factory (pre-prepare* opts)] (let [factory (pre-prepare* opts)]
(reify clojure.lang.IReduceInit (reify clojure.lang.IReduceInit
(reduce [_ f init] (reduce [_ f init]
(with-open [stmt (prepare-fn this sql-params factory)] (with-open [stmt (prepare-fn this sql params factory)]
(reduce-stmt stmt f init)))))) (reduce-stmt stmt f init))))))
DataSource DataSource
(-execute [this sql-params opts] (-execute [this [sql & params] opts]
(let [factory (pre-prepare* opts)] (let [factory (pre-prepare* opts)]
(reify clojure.lang.IReduceInit (reify clojure.lang.IReduceInit
(reduce [_ f init] (reduce [_ f init]
(with-open [con (get-connection this opts)] (with-open [con (get-connection this opts)]
(with-open [stmt (prepare-fn con sql-params factory)] (with-open [stmt (prepare-fn con sql params factory)]
(reduce-stmt stmt f init))))))) (reduce-stmt stmt f init)))))))
PreparedStatement PreparedStatement
(-execute [this _ _] (-execute [this _ _]
@ -560,7 +560,7 @@
value)) value))
(quick-bench (select* con)) (quick-bench (select* con))
;; same as the Java example in java.jdbc perf test ;; almost same as the Java example above
(quick-bench (quick-bench
(reduce (fn [rs m] (reduced (:name m))) (reduce (fn [rs m] (reduced (:name m)))
nil nil