diff --git a/CHANGELOG.md b/CHANGELOG.md index 2f0ea70..2baf520 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ Only accretive/fixative changes will be made from now on. Changes made on **develop** since the 1.1.547 release: +* Fix #132 by adding specs for `next.jdbc/with-options` and `next.jdbc.prepare/statement`; correct spec for `next.jdbc.connection/component`. PR #131 from @Briaoeuidhtns. * Fix #130 by implementing `clojure.lang.ILookup` on the three builder adapters. * Fix #129 by adding `with-column-value` to `RowBuilder` and a more generic `builder-adapter`. * Fix #128 by adding a test for the "not found" arity of lookup on mapified result sets. diff --git a/src/next/jdbc/specs.clj b/src/next/jdbc/specs.clj index 7e83d28..99ccc9d 100644 --- a/src/next/jdbc/specs.clj +++ b/src/next/jdbc/specs.clj @@ -110,10 +110,6 @@ :sql-params ::sql-params :opts (s/? ::opts-map))) -(s/fdef jdbc/statement - :args (s/cat :connection ::connection - :opts (s/? ::opts-map))) - (s/fdef jdbc/plan :args (s/alt :prepared (s/cat :stmt ::statement) :sql (s/cat :connectable ::connectable @@ -137,6 +133,10 @@ :f fn? :opts (s/? ::opts-map))) +(s/fdef jdbc/with-options + :args (s/cat :connectable ::connectable + :opts ::opts-map)) + (s/fdef jdbc/with-transaction :args (s/cat :binding (s/and vector? (s/cat :sym simple-symbol? @@ -151,7 +151,7 @@ (s/fdef connection/component :args (s/cat :clazz #(instance? Class %) :db-spec ::db-spec-or-jdbc - :close-fn (s/? ifn?))) + :close-fn (s/? fn?))) (s/fdef prepare/execute-batch! :args (s/cat :ps ::prepared-statement @@ -162,6 +162,10 @@ :args (s/cat :ps ::prepared-statement :params ::params)) +(s/fdef prepare/statement + :args (s/cat :connection ::connection + :opts (s/? ::opts-map))) + (s/fdef sql/insert! :args (s/cat :connectable ::connectable :table keyword? @@ -228,7 +232,9 @@ `jdbc/execute-one! `jdbc/transact `jdbc/with-transaction + `jdbc/with-options `connection/->pool + `connection/component `prepare/execute-batch! `prepare/set-parameters `prepare/statement