luciano/next-jdbc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #257

Browse source
This commit is contained in:
Sean Corfield 2023-09-15 15:58:18 -07:00
parent abd926cde3
commit c8cf8c7d2f
2 changed files with 26 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -3,6 +3,7 @@
Only accretive/fixative changes will be made from now on. Only accretive/fixative changes will be made from now on.
* 1.3.next in progress * 1.3.next in progress
* Fix [#257](https://github.com/seancorfield/next-jdbc/issues/257) by making the `fdef` spec for `with-transaction` more permissive. Also add specs for `on-connection` and the `+options` variants of both macros.
* Address [#256](https://github.com/seancorfield/next-jdbc/issues/256) by adding `with-transaction+options` and `on-connection+options`. Documentation TBD. * Address [#256](https://github.com/seancorfield/next-jdbc/issues/256) by adding `with-transaction+options` and `on-connection+options`. Documentation TBD.
* Update `tools.build` to 0.9.5 (and remove `:java-opts` from `build/test`) * Update `tools.build` to 0.9.5 (and remove `:java-opts` from `build/test`)

31
src/next/jdbc/specs.clj
View file

@ -1,4 +1,4 @@
;; copyright (c) 2019-2021 Sean Corfield, all rights reserved ;; copyright (c) 2019-2023 Sean Corfield, all rights reserved
(ns next.jdbc.specs (ns next.jdbc.specs
"Specs for the core API of next.jdbc. "Specs for the core API of next.jdbc.
@ -151,11 +151,30 @@
:opts ::opts-map)) :opts ::opts-map))
(s/fdef jdbc/with-transaction (s/fdef jdbc/with-transaction
:args (s/cat :binding (s/and vector? :args (s/cat :binding (s/and vector?
(s/cat :sym simple-symbol? (s/cat :sym simple-symbol?
:transactable ::transactable :transactable ::transactable
:opts (s/? ::opts-map))) :opts (s/? any?)))
:body (s/* any?))) :body (s/* any?)))
(s/fdef jdbc/with-transaction+options
:args (s/cat :binding (s/and vector?
(s/cat :sym simple-symbol?
:transactable ::transactable
:opts (s/? any?)))
:body (s/* any?)))
(s/fdef jdbc/on-connection
:args (s/cat :binding (s/and vector?
(s/cat :sym simple-symbol?
:connectable ::connectable))
:body (s/* any?)))
(s/fdef jdbc/on-connection+options
:args (s/cat :binding (s/and vector?
(s/cat :sym simple-symbol?
:connectable ::connectable))
:body (s/* any?)))
(s/fdef connection/->pool (s/fdef connection/->pool
:args (s/cat :clazz #(instance? Class %) :args (s/cat :clazz #(instance? Class %)