luciano/nippy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

optimize type range checks in freeze-to-out* (10x faster)

Browse source
This commit is contained in:
Karsten Schmidt 2015-09-15 14:17:03 +01:00
parent 140171393c
commit f2f8b419b1
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/taoensso/nippy.clj
View file

@ -162,11 +162,11 @@
(defmacro write-id [out id] `(.writeByte ~out ~id)) (defmacro write-id [out id] `(.writeByte ~out ~id))
(defmacro write-bytes [out ba & [small?]] (defmacro write-bytes [out ba & [small?]]
(let [out (with-meta out {:tag 'java.io.DataOutput}) (let [out (with-meta out {:tag 'java.io.DataOutput})
ba (with-meta ba {:tag 'bytes}) ba (with-meta ba {:tag 'bytes})
;; Optimization, must be known before id's written ;; Optimization, must be known before id's written
;; `byte` to throw on range error ;; `byte` to throw on range error
[wc wr] (if small? [byte 'writeByte] [int 'writeInt])] [wc wr] (if small? [byte 'writeByte] [int 'writeInt])]
`(let [out# ~out, ba# ~ba `(let [out# ~out, ba# ~ba
size# (alength ba#)] size# (alength ba#)]
(. out# ~wr (~wc size#)) (. out# ~wr (~wc size#))
@ -292,13 +292,13 @@
Freezable Freezable
(freeze-to-out* [x ^DataOutput out] (freeze-to-out* [x ^DataOutput out]
(cond (cond
(<= Byte/MIN_VALUE x Byte/MAX_VALUE) (and (<= Byte/MIN_VALUE x) (<= x Byte/MAX_VALUE))
(do (write-id out id-byte-as-long) (.writeByte out x)) (do (write-id out id-byte-as-long) (.writeByte out x))
(<= Short/MIN_VALUE x Short/MAX_VALUE) (and (<= Short/MIN_VALUE x) (<= x Short/MAX_VALUE))
(do (write-id out id-short-as-long) (.writeShort out x)) (do (write-id out id-short-as-long) (.writeShort out x))
(<= Integer/MIN_VALUE x Integer/MAX_VALUE) (and (<= Integer/MIN_VALUE x) (<= x Integer/MAX_VALUE))
(do (write-id out id-int-as-long) (.writeInt out x)) (do (write-id out id-int-as-long) (.writeInt out x))
:else (do (write-id out id-long) (.writeLong out x))))) :else (do (write-id out id-long) (.writeLong out x)))))