luciano/pods
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pass pod resolve-fn to describe->metadata

Browse source 
Not only was this just a bug, but the accidental reference to clojure.core/resolve ballooned the final bb image size to >110MB!
This commit is contained in:
Wes Morgan 2022-03-22 12:21:42 -06:00
parent 599cdc0157
commit 1b77a936d6
No known key found for this signature in database
GPG key ID: 5639E4CBFA17DC84
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/babashka/pods/impl.clj
View file

@ -367,11 +367,11 @@
(defn describe->ops [describe-reply] (defn describe->ops [describe-reply]
(some->> (get describe-reply "ops") keys (map keyword) set)) (some->> (get describe-reply "ops") keys (map keyword) set))
(defn describe->metadata [describe-reply] (defn describe->metadata [describe-reply resolve-fn]
(let [format (-> (get describe-reply "format") bytes->string keyword) (let [format (-> (get describe-reply "format") bytes->string keyword)
ops (describe->ops describe-reply) ops (describe->ops describe-reply)
readers (when (identical? :edn format) readers (when (identical? :edn format)
(read-readers describe-reply resolve))] (read-readers describe-reply resolve-fn))]
{:format format, :ops ops, :readers readers})) {:format format, :ops ops, :readers readers}))
(defn load-pod-metadata [pod-spec opts] (defn load-pod-metadata [pod-spec opts]
@ -394,7 +394,7 @@
reply (or (:metadata opts) reply (or (:metadata opts)
(describe-pod running-pod)) (describe-pod running-pod))
{:keys [:format :ops :readers]} (describe->metadata reply) {:keys [:format :ops :readers]} (describe->metadata reply resolve)
pod {:process p pod {:process p
:pod-spec pod-spec :pod-spec pod-spec
:stdin stdin :stdin stdin