luciano/reitit
1
0
Fork 0
mirror of https://github.com/metosin/reitit.git synced 2025-12-18 08:51:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove unsupported coercions when generating swagger

Browse source 
If we don't remove them, :responses :content gets passed out verbatim
in the swagger.json, breaking stuff.

In particular, fixes the swagger.json in
examples/reitit-malli-swagger. Reported broken in #669.
This commit is contained in:
Joel Kaasinen 2024-04-19 09:35:09 +03:00
parent fbec1e2ecc
commit 01b476b342
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/reitit-swagger/src/reitit/swagger.cljc
View file

@ -68,11 +68,13 @@
(defn- swagger-path [path opts] (defn- swagger-path [path opts]
(-> path (trie/normalize opts) (str/replace #"\{\*" "{"))) (-> path (trie/normalize opts) (str/replace #"\{\*" "{")))
(defn -warn-unsupported-coercions [{:keys [request responses] :as _data}] (defn -remove-unsupported-coercions [{:keys [request responses] :as data}]
(when request (when request
(println "WARNING [reitit.coercion]: swagger apidocs don't support :request coercion")) (println "WARNING [reitit.coercion]: swagger apidocs don't support :request coercion"))
(when (some :content (vals responses)) (when (some :content (vals responses))
(println "WARNING [reitit.coercion]: swagger apidocs don't support :responses :content coercion"))) (println "WARNING [reitit.coercion]: swagger apidocs don't support :responses :content coercion"))
(cond-> (dissoc data :request)
responses (assoc :responses (update-vals responses #(dissoc % :content)))))
(defn -get-swagger-apidocs [coercion data] (defn -get-swagger-apidocs [coercion data]
(let [swagger-parameter {:query :query (let [swagger-parameter {:query :query
@ -80,10 +82,10 @@
:form :formData :form :formData
:header :header :header :header
:path :path :path :path
:multipart :formData}] :multipart :formData}
(-warn-unsupported-coercions data) cleaned (-remove-unsupported-coercions data)]
(->> (update (->> (update
data cleaned
:parameters :parameters
(fn [parameters] (fn [parameters]
(->> parameters (->> parameters