From 75149b595f0405636d10731eac7bfab10c88696f Mon Sep 17 00:00:00 2001 From: Aaron Groom Date: Tue, 2 Apr 2019 15:43:57 -0400 Subject: [PATCH 1/3] Remove unneeded comma --- doc/basics/name_based_routing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/basics/name_based_routing.md b/doc/basics/name_based_routing.md index 5f66d0f6..97016b3d 100644 --- a/doc/basics/name_based_routing.md +++ b/doc/basics/name_based_routing.md @@ -1,6 +1,6 @@ # Name-based (reverse) Routing -All routes which have `:name` route data defined, can also be matched by name. +All routes which have `:name` route data defined can also be matched by name. Given a router: From aeab44e6e5bf120d1ec20d894e3859195858bf22 Mon Sep 17 00:00:00 2001 From: Aaron Groom Date: Tue, 2 Apr 2019 15:44:24 -0400 Subject: [PATCH 2/3] Add missing word to sentence --- doc/basics/route_conflicts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/basics/route_conflicts.md b/doc/basics/route_conflicts.md index b401a61f..4f6a02c9 100644 --- a/doc/basics/route_conflicts.md +++ b/doc/basics/route_conflicts.md @@ -1,6 +1,6 @@ # Route Conflicts -We should fast if a router contains conflicting paths or route names. +We should fail fast if a router contains conflicting paths or route names. When a `Router` is created via `reitit.core/router`, both path and route name conflicts are checked automatically. By default, in case of conflict, an `ex-info` is thrown with a descriptive message. In some (legacy api) cases, path conflicts should be allowed and one can override the path conflict resolution via `:conflicts` router option. From ffc4d8e5c63f3842960d6ef06139a3178e0729cd Mon Sep 17 00:00:00 2001 From: Aaron Groom Date: Tue, 2 Apr 2019 15:45:13 -0400 Subject: [PATCH 3/3] Remove extraneous word --- doc/basics/route_data_validation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/basics/route_data_validation.md b/doc/basics/route_data_validation.md index bc98ea1a..b3b9cde9 100644 --- a/doc/basics/route_data_validation.md +++ b/doc/basics/route_data_validation.md @@ -1,6 +1,6 @@ # Route Data Validation -Route data can be anything, so it's easy to do go wrong. Accidentally adding a `:role` key instead of `:roles` might hinder the whole routing app without any authorization in place. +Route data can be anything, so it's easy to go wrong. Accidentally adding a `:role` key instead of `:roles` might hinder the whole routing app without any authorization in place. To fail fast, we could use the custom `:coerce` and `:compile` hooks to apply data validation and throw exceptions on first sighted problem.