test: Use atom in reloading-ring-handler-test

This removes usage of inline defs.
This commit is contained in:
Mathieu Lirzin 2026-01-01 17:19:51 +01:00
parent e4c53a64e2
commit 54a040f136
No known key found for this signature in database
GPG key ID: 0ADEE10094604D37

View file

@ -848,23 +848,22 @@
(let [body (:body (app {:request-method :get, :uri (str "/" n)}))] (let [body (:body (app {:request-method :get, :uri (str "/" n)}))]
(is (= body (str n)))))))))))) (is (= body (str n))))))))))))
(declare routes) (def routes (atom nil))
(deftest reloading-ring-handler-test (deftest reloading-ring-handler-test
(let [r (fn [body] {:status 200, :body body})] (let [r (fn [body] {:status 200, :body body})]
(def routes ["/" (constantly (r "1"))]) ;; initial value (reset! routes ["/" (constantly (r "1"))]) ;; initial value
(let [create-handler (fn [] (ring/ring-handler (ring/router @routes)))]
(let [create-handler (fn [] (ring/ring-handler (ring/router routes)))]
(testing "static ring handler does not see underlying route changes" (testing "static ring handler does not see underlying route changes"
(let [app (create-handler)] (let [app (create-handler)]
(is (= (r "1") (app {:uri "/", :request-method :get}))) (is (= (r "1") (app {:uri "/", :request-method :get})))
(def routes ["/" (constantly (r "2"))]) ;; redefine (reset! routes ["/" (constantly (r "2"))]) ;; redefine
(is (= (r "1") (app {:uri "/", :request-method :get}))))) (is (= (r "1") (app {:uri "/", :request-method :get})))))
(testing "reloading ring handler sees underlying route changes" (testing "reloading ring handler sees underlying route changes"
(let [app (ring/reloading-ring-handler create-handler)] (let [app (ring/reloading-ring-handler create-handler)]
(is (= (r "2") (app {:uri "/", :request-method :get}))) (is (= (r "2") (app {:uri "/", :request-method :get})))
(def routes ["/" (constantly (r "3"))]) ;; redefine again (reset! routes ["/" (constantly (r "3"))]) ;; redefine again
(is (= (r "3") (app {:uri "/", :request-method :get})))))))) (is (= (r "3") (app {:uri "/", :request-method :get}))))))))
(defrecord FooTest [a b]) (defrecord FooTest [a b])