luciano/reitit
1
0
Fork 0
mirror of https://github.com/metosin/reitit.git synced 2025-12-24 10:58:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Support stripping multiple slashes

Browse source 
One inspiration for stripping/adding slashes automatically in reitit was
https://github.com/julienschmidt/httprouter which can handle any number
of slashes. Make the implementation a bit better by stripping as many
slashes as there are.

This still doesn't support redirecting from a multiple-slash URI to a
single-slash URI. That could be handled as a special case, but in the
end I think the correct solution would be to convert both the router and
request URIs to a canonical form before matching. Then the question of
slashes is just a question of formatting.
This commit is contained in:
Hannu Hartikainen 2018-10-31 09:48:13 +02:00
parent d24f86ccfe
commit 6a7fb095cb
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/reitit-ring/src/reitit/ring.cljc
View file

@ -131,7 +131,7 @@
(let [uri (:uri request)]
(if (str/ends-with? uri "/")
(if (not= method :add)
(maybe-redirect request (subs uri 0 (-> uri count dec))))
(maybe-redirect request (str/replace-first uri #"/+$" "")))
(if (not= method :strip)
(maybe-redirect request (str uri "/"))))))]
(fn

12
test/cljc/reitit/ring_test.cljc
View file

@ -281,7 +281,11 @@
(testing "strips slashes"
(is (= 301 (:status (app {:request-method :get, :uri "/slash-less/"}))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less/"})))))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less/"})))))
(testing "strips multiple slashes"
(is (= 301 (:status (app {:request-method :get, :uri "/slash-less/////"}))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less//"})))))))
(testing "without option (equivalent to using :method :both)"
(let [app (ring/ring-handler
@ -300,7 +304,11 @@
(testing "strips slashes"
(is (= 301 (:status (app {:request-method :get, :uri "/slash-less/"}))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less/"})))))))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less/"})))))
(testing "strips multiple slashes"
(is (= 301 (:status (app {:request-method :get, :uri "/slash-less/////"}))))
(is (= 308 (:status (app {:request-method :post, :uri "/slash-less//"})))))))))
(deftest async-ring-test
(let [promise #(let [value (atom ::nil)]