luciano/reitit
1
0
Fork 0
mirror of https://github.com/metosin/reitit.git synced 2025-12-27 11:58:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add tests for intermediate paths in Ring

Browse source 
Added failing tests for resolving intermediate paths with Ring.
Handlers are inherited by children, but names are consumed by intermediate routes
See Github issue #175
This commit is contained in:
Toni Vanhala 2019-10-16 13:18:19 +03:00
parent 0faf2af876
commit 6bf4335f84
1 changed files with 38 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
test/cljc/reitit/ring_test.cljc
View file

@ -1,5 +1,5 @@
(ns reitit.ring-test
(:require [clojure.test :refer [deftest testing is]]
(:require [clojure.test :refer [deftest testing is are]]
[clojure.set :as set]
[reitit.middleware :as middleware]
[reitit.ring :as ring]
@ -116,7 +116,43 @@
(testing "all named routes can be matched"
(doseq [name (r/route-names router)]
(is (= name (-> (r/match-by-name router name) :data :name))))))))
(is (= name (-> (r/match-by-name router name) :data :name)))))))
(testing "intermediate paths"
(testing "without conflicts"
(let [routes ["/" {:get {:handler handler} :name ::root}
["foo" {:name ::foo}] ;; Inherits handler from above
["bar" {:get {:handler handler} :name ::bar}
["/baz" {:get {:handler handler} :name ::baz}]]
["bang" {}
["/bang"]]
["ping" {:name ::ping}
["/pong" {:get {:handler handler} :name ::pong}]]]
router (ring/router routes)
match #(r/match-by-path router %)]
(are [path name]
(is (= name (-> (match path) :data :name)))
"/" ::root
"/foo" ::foo
"/bar" ::bar
"/bar/baz" ::baz
"/ping" ::ping
"/ping/pong" ::pong)
(is (nil? (match "/bang")))
(is (-> (match "/bang/bang") :data :get :handler))))
(testing "with conflicts"
(let [routes ["/" {:get {:handler handler} :name ::root}
["" {:name ::other-root}] ;; Conflicts with ::root path
["foo" {:name ::foo}]
["bar" {:get {:handler handler} :name ::bar}
["/baz" {:get {:handler handler} :name ::baz}]]
["ping" {:name ::ping}
["/pong" {:get {:handler handler} :name ::pong}]]]]
(is (thrown-with-msg?
ExceptionInfo
#"Router contains conflicting route paths"
(ring/router routes)))))))
(defn wrap-enforce-roles [handler]
(fn [{::keys [roles] :as request}]