luciano/reitit
1
0
Fork 0
mirror of https://github.com/metosin/reitit.git synced 2025-12-17 08:21:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add support for default values

Browse source
This commit is contained in:
Tommi Reiman 2019-12-30 22:58:05 +02:00
parent 5df07ea0cf
commit 91a2945578
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/reitit-malli/src/reitit/coercion/malli.cljc
View file

@ -16,15 +16,19 @@
(def string-transformer (def string-transformer
(mt/transformer (mt/transformer
mt/strip-extra-keys-transformer mt/strip-extra-keys-transformer
mt/string-transformer)) mt/string-transformer
mt/default-value-transformer))
(def json-transformer (def json-transformer
(mt/transformer (mt/transformer
mt/strip-extra-keys-transformer mt/strip-extra-keys-transformer
mt/json-transformer)) mt/json-transformer
mt/default-value-transformer))
(def default-transformer (def default-transformer
mt/strip-extra-keys-transformer) (mt/transformer
mt/strip-extra-keys-transformer
mt/default-value-transformer))
;; TODO: are these needed? ;; TODO: are these needed?
(defmulti coerce-response? identity :default ::default) (defmulti coerce-response? identity :default ::default)
@ -107,7 +111,7 @@
:response {:default default-transformer :response {:default default-transformer
:formats {"application/json" json-transformer}}} :formats {"application/json" json-transformer}}}
;; set of keys to include in error messages ;; set of keys to include in error messages
:error-keys #{:type :coercion :in #_:schema #_:value :errors :humanized #_:transformed} :error-keys #{:type :coercion :in :schema :value :errors :humanized #_:transformed}
;; malli options ;; malli options
:options nil}) :options nil})

6
test/cljc/reitit/ring_coercion_test.cljc
View file

@ -207,7 +207,7 @@
["/plus/:e" ["/plus/:e"
{:get {:parameters {:query [:map [:a {:optional true} int?]] {:get {:parameters {:query [:map [:a {:optional true} int?]]
:body [:map [:b int?]] :body [:map [:b int?]]
:form [:map [:c int?]] :form [:map [:c [int? {:default 3}]]]
:header [:map [:d int?]] :header [:map [:d int?]]
:path [:map [:e int?]]} :path [:map [:e int?]]}
:responses {200 {:body [:map [:total pos-int?]]} :responses {200 {:body [:map [:total pos-int?]]}
@ -230,6 +230,10 @@
(is (= {:status 200 (is (= {:status 200
:body {:total 15}} :body {:total 15}}
(app valid-request3))) (app valid-request3)))
(testing "default values work"
(is (= {:status 200
:body {:total 15}}
(app (update valid-request3 :form-params dissoc :c)))))
(is (= {:status 500 (is (= {:status 500
:body {:evil true}} :body {:evil true}}
(app (assoc-in valid-request1 [:query-params "a"] "666"))))) (app (assoc-in valid-request1 [:query-params "a"] "666")))))