luciano/specter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

collect-val instead of collect*

Browse source
This commit is contained in:
Nathan Marz 2015-09-11 01:42:29 -04:00
parent ae679b6cc1
commit 2a30a6aba5
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/com/rpl/specter.cljc
View file

@ -3,10 +3,6 @@
(:require [com.rpl.specter.impl :as i]) (:require [com.rpl.specter.impl :as i])
) )
;;TODO: can make usage of vals much more efficient by determining during composition how many vals
;;there are going to be. this should make it much easier to allocate space for vals without doing concats
;;all over the place. The apply to the vals + structure can also be avoided since the number of vals is known
;;beforehand
(defn comp-paths [& paths] (defn comp-paths [& paths]
(i/comp-paths* (vec paths))) (i/comp-paths* (vec paths)))
@ -108,9 +104,9 @@
[selector transform-fn structure & {:keys [merge-fn] :or {merge-fn concat}}] [selector transform-fn structure & {:keys [merge-fn] :or {merge-fn concat}}]
(compiled-replace-in (i/comp-paths* selector) transform-fn structure :merge-fn merge-fn)) (compiled-replace-in (i/comp-paths* selector) transform-fn structure :merge-fn merge-fn))
(def bind-params* i/bind-params*) ;; Helpers for defining selectors and collectors with late-bound params
;; paramspath* [bindings num-params-sym [impl1 impl2]] (def bind-params* i/bind-params*)
(defmacro paramspath [params & impls] (defmacro paramspath [params & impls]
(let [num-params (count params) (let [num-params (count params)
@ -290,13 +286,13 @@
(defn collect [& path] (defn collect [& path]
(pathed-collector [late path] (pathed-collector [late path]
(collect* [this structure] (collect-val [this structure]
(compiled-select late structure) (compiled-select late structure)
))) )))
(defn collect-one [& path] (defn collect-one [& path]
(pathed-collector [late path] (pathed-collector [late path]
(collect* [this structure] (collect-val [this structure]
(compiled-select-one late structure) (compiled-select-one late structure)
))) )))
@ -309,7 +305,7 @@
; e.g., incrementing val at path [:a :b] by 3: ; e.g., incrementing val at path [:a :b] by 3:
; (transform [:a :b (putval 3)] + some-map)" ; (transform [:a :b (putval 3)] + some-map)"
(defparamscollector putval [val] (defparamscollector putval [val]
(collect* [this structure] (collect-val [this structure]
val )) val ))
;;TODO: test nothing matches case ;;TODO: test nothing matches case