inline caching for cljs working in repl tests, tests not working for cljs yet

This commit is contained in:
Nathan Marz 2016-05-23 09:23:14 -04:00
parent d30af6e972
commit ac8119dbbe
3 changed files with 54 additions and 42 deletions

View file

@ -9,8 +9,8 @@
:auto-clean false :auto-clean false
:dependencies [[org.clojure/tools.macro "0.1.2"]] :dependencies [[org.clojure/tools.macro "0.1.2"]]
:profiles {:provided {:dependencies :profiles {:provided {:dependencies
[[org.clojure/clojure "1.7.0"] [[org.clojure/clojure "1.6.0"]
[org.clojure/clojurescript "1.7.122"]]} [org.clojure/clojurescript "0.0-3211"]]}
:dev {:dependencies :dev {:dependencies
[[org.clojure/test.check "0.7.0"]] [[org.clojure/test.check "0.7.0"]]
:plugins :plugins

View file

@ -16,8 +16,9 @@
(:import [com.rpl.specter Util]) (:import [com.rpl.specter Util])
) )
(defn spy [e] (defn spy [e]
(println e) (println (pr-str e))
e) e)
(defprotocol PathComposer (defprotocol PathComposer
@ -676,13 +677,6 @@
(satisfies? p/Collector v) (satisfies? p/Collector v)
(instance? CompiledPath v))) (instance? CompiledPath v)))
#+clj
(def ^:dynamic *used-locals*)
#+clj
(defmacro handle-params [precompiled params-maker possible-params]
`(bind-params* ~precompiled (~params-maker ~@*used-locals*) 0))
#+cljs #+cljs
(defn handle-params [precompiled params-maker possible-params] (defn handle-params [precompiled params-maker possible-params]
(let [params (fast-object-array (count params-maker))] (let [params (fast-object-array (count params-maker))]

View file

@ -349,13 +349,22 @@
(do (do
(mapcat (mapcat
(fn [e] (fn [e]
(if (i/fn-invocation? e) (cond (i/fn-invocation? e)
(concat (-> e rest) (ic-possible-params e)))) (concat (-> e rest) (ic-possible-params e))
(vector? e)
(ic-possible-params e)
))
path))) path)))
;; still possible to mess this up with alter-var-root ;; still possible to mess this up with alter-var-root
(defmacro path [& path] ; "inline cache" (defmacro path [& path] ; "inline cache"
(let [local-syms (-> &env keys set) (let [;;this is a hack, but the composition of &env is considered stable for cljs
platform (if (contains? &env :locals) :cljs :clj)
local-syms (if (= platform :cljs)
(-> &env :locals keys set) ;cljs
(-> &env keys set) ;clj
)
used-locals (vec (i/walk-select local-syms vector path)) used-locals (vec (i/walk-select local-syms vector path))
prepared-path (ic-prepare-path local-syms (walk/macroexpand-all (vec path))) prepared-path (ic-prepare-path local-syms (walk/macroexpand-all (vec path)))
possible-params (vec (ic-possible-params path)) possible-params (vec (ic-possible-params path))
@ -369,10 +378,20 @@
;; to invoke and/or parameterize the precompiled path without ;; to invoke and/or parameterize the precompiled path without
;; a bunch of checks beforehand ;; a bunch of checks beforehand
cache-id (str (java.util.UUID/randomUUID)) cache-id (str (java.util.UUID/randomUUID))
precompiled-sym (gensym "precompiled")
params-maker-sym (gensym "params-maker")
handle-params-code
(if (= platform :clj)
`(i/bind-params* ~precompiled-sym (~params-maker-sym ~@used-locals) 0)
`(i/handle-params
~precompiled-sym
~params-maker-sym
~(mapv (fn [p] `(fn [] ~p)) possible-params)
))
] ]
(binding [i/*used-locals* used-locals]
;; in order to pass the used locals to the clj handle-params macro ;; in order to pass the used locals to the clj handle-params macro
(walk/macroexpand-all
`(let [info# (i/get-path-cache ~cache-id) `(let [info# (i/get-path-cache ~cache-id)
^com.rpl.specter.impl.CachedPathInfo info# ^com.rpl.specter.impl.CachedPathInfo info#
@ -381,24 +400,23 @@
(let [info# (i/magic-precompilation (let [info# (i/magic-precompilation
~prepared-path ~prepared-path
(quote ~used-locals) (quote ~used-locals)
;;possible-params is wrong atm
;;as is used-locals in cljs...
(quote ~possible-params) (quote ~possible-params)
)] )]
(i/add-path-cache! ~cache-id info#) (i/add-path-cache! ~cache-id info#)
info# info#
)) ))
precompiled# (.-precompiled info#) ~precompiled-sym (.-precompiled info#)
params-maker# (.-params-maker info#)] ~params-maker-sym (.-params-maker info#)]
(if (some? precompiled#) (if (some? ~precompiled-sym)
(if (nil? params-maker#) (if (nil? ~params-maker-sym)
precompiled# ~precompiled-sym
(i/handle-params ~handle-params-code
precompiled# )
params-maker#
~(mapv (fn [p] `(fn [] ~p)) possible-params)
))
(i/comp-paths* ~(vec path)) (i/comp-paths* ~(vec path))
)))) ))
)) ))
(defmacro select [apath structure] (defmacro select [apath structure]