luciano/telemere
1
0
Fork 0
mirror of https://github.com/taoensso/telemere.git synced 2025-12-17 18:01:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[fix] Line info missing from OpenTelemetry output
Some checks failed
Clj tests / tests (17, ubuntu-latest) (push) Has been cancelled
Details
Clj tests / tests (19, ubuntu-latest) (push) Has been cancelled
Details
Clj tests / tests (21, ubuntu-latest) (push) Has been cancelled
Details
Cljs tests / tests (21, ubuntu-latest) (push) Has been cancelled
Details
Graal tests / tests (17, macOS-latest) (push) Has been cancelled
Details
Graal tests / tests (17, ubuntu-latest) (push) Has been cancelled
Details
Graal tests / tests (17, windows-latest) (push) Has been cancelled
Details

Browse source 
Previous code was a vestigial leftover from when signals
had {:line <num> :column <num> ...} rather than
{:coords [<line-num> <column-num>] ...}
This commit is contained in:
Peter Taoussanis 2025-11-05 07:00:17 +01:00
parent ff31519d8f
commit 38f4246145
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
main/src/taoensso/telemere/open_telemetry.clj
View file

@ -219,15 +219,15 @@
(if (or common-attrs trace-attrs) (if (or common-attrs trace-attrs)
(let [ab (Attributes/builder)] (let [ab (Attributes/builder)]
(when-let [ns (get signal :ns)] (.put ab "ns" (str ns))) (when-let [ns (get signal :ns)] (.put ab "ns" (str ns)))
(when-let [line (get signal :line)] (.put ab "line" (long line))) (when-let [line (enc/get-in* signal [:coords 0])] (.put ab "line" (long line)))
(when-let [attrs common-attrs] (put-attrs! ab attrs)) (when-let [attrs common-attrs] (put-attrs! ab attrs))
(when-let [attrs trace-attrs] (put-attrs! ab attrs)) (when-let [attrs trace-attrs] (put-attrs! ab attrs))
(.build ab)) (.build ab))
;; Common case ;; Common case
(when-let [ns (get signal :ns)] (when-let [ns (get signal :ns)]
(if-let [line (get signal :line)] (if-let [line (enc/get-in* signal [:coords 0])]
(Attributes/of ak-ns ns, ak-line (long line)) (Attributes/of ak-ns ns, ak-line (long line))
(Attributes/of ak-ns ns))))))) (Attributes/of ak-ns ns)))))))