luciano/telemere
1
0
Fork 0
mirror of https://github.com/taoensso/telemere.git synced 2026-01-29 09:20:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[new] OpenTelemetry handler: add extra auto span attrs

Browse source
This commit is contained in:
Peter Taoussanis 2024-08-19 11:09:55 +02:00
parent e323896d54
commit ae7bb20ed0
1 changed files with 80 additions and 50 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

86
src/taoensso/telemere/open_telemetry.clj
View file

@ -163,19 +163,10 @@
(comment (enc/qb 1e6 (remote-span-context "c5b856d919f65e39a202bfb3034d65d8" "9740419096347616" false {"a" "A"}))) ; 111.13 (comment (enc/qb 1e6 (remote-span-context "c5b856d919f65e39a202bfb3034d65d8" "9740419096347616" false {"a" "A"}))) ; 111.13
(def ^:private ^String span-name
(enc/fmemoize
(fn [id]
#_(if id (str id) ":telemere/nil-id")
(if id (enc/as-qname id) "telemere/nil-id"))))
(comment (enc/qb 1e6 (span-name :foo/bar))) ; 46.09
(let [span-name span-name]
(defn- start-span (defn- start-span
"Returns new `io.opentelemetry.api.trace.Span` with random `traceId` and `spanId`." "Returns new `io.opentelemetry.api.trace.Span` with random `traceId` and `spanId`."
^Span [^Tracer tracer ?id ?uid ^java.time.Instant inst ?parent] ^Span [^Tracer tracer ^String span-name ^java.time.Instant inst ?parent]
(let [sb (.spanBuilder tracer (span-name ?id))] (let [sb (.spanBuilder tracer span-name)]
(when-let [parent ?parent] (when-let [parent ?parent]
(cond (cond
;; Local parent span, etc. ;; Local parent span, etc.
@ -196,20 +187,44 @@
#{io.opentelemetry.api.trace.Span #{io.opentelemetry.api.trace.Span
io.opentelemetry.api.trace.SpanContext}}))) io.opentelemetry.api.trace.SpanContext}})))
(when-let [uid ?uid]
(.setAttribute sb "uid" (str uid)))
(.setStartTimestamp sb inst) (.setStartTimestamp sb inst)
(.startSpan sb)))) (.startSpan sb)))
(comment (comment
(let [inst (enc/now-inst)] (enc/qb 1e6 (start-span my-tr :id1 :uid1 inst nil))) ; 217.47 (let [inst (enc/now-inst)] (enc/qb 1e6 (start-span my-tr "id1" inst nil))) ; 142.33
(start-span my-tr :id1 :uid1 (enc/now-inst) (start-span my-tr :id2 :uid2 (enc/now-inst) nil)) (start-span my-tr "id1" (enc/now-inst) (start-span my-tr "id2" (enc/now-inst) nil))
(start-span my-tr :id1 :uid1 (enc/now-inst) (start-span my-tr "id1" (enc/now-inst)
(remote-span-context "c5b856d919f65e39a202bfb3034d65d8" "1111111111111111" false nil))) (remote-span-context "c5b856d919f65e39a202bfb3034d65d8" "1111111111111111" false nil)))
(enc/def* ^:private (let [ak-uid (io.opentelemetry.api.common.AttributeKey/stringKey "uid")
^io.opentelemetry.api.common.AttributeKey uid-attr-key ak-ns (io.opentelemetry.api.common.AttributeKey/stringKey "ns")
(io.opentelemetry.api.common.AttributeKey/stringKey "uid")) ak-line (io.opentelemetry.api.common.AttributeKey/longKey "line")]
(defn- span-attrs
"Returns `io.opentelemetry.api.common.Attributes` or nil."
[uid signal]
(if uid
(if-let [ns (get signal :ns)]
(if-let [line (get signal :line)]
(Attributes/of ak-uid (str uid), ak-ns ns, ak-line line)
(Attributes/of ak-uid (str uid), ak-ns ns))
(Attributes/of ak-uid (str uid)))
(if-let [ns (get signal :ns)]
(if-let [line (get signal :line)]
(Attributes/of ak-ns ns, ak-line line)
(Attributes/of ak-ns ns))
nil))))
(comment (enc/qb 1e6 (span-attrs "uid1" {:ns "ns1" :line 495}))) ; 100.91
(def ^:private ^String span-name
(enc/fmemoize
(fn [id]
#_(if id (str id) ":telemere/nil-id")
(if id (enc/as-qname id) "telemere/nil-id"))))
(comment (enc/qb 1e6 (span-name :foo/bar))) ; 46.09
(defn- handle-tracing! (defn- handle-tracing!
"Experimental! Takes care of relevant signal `Span` management. "Experimental! Takes care of relevant signal `Span` management.
@ -247,7 +262,8 @@
(or old (or old
(delay (delay
;; TODO Support remote-span-context parent and/or span links? ;; TODO Support remote-span-context parent and/or span links?
(start-span tracer root-id root-uid root-inst nil)))))))))] (start-span tracer (span-name root-id)
root-inst nil)))))))))]
(let [?parent-span ; May be identical to root-span (let [?parent-span ; May be identical to root-span
(when-let [parent (get signal :parent)] (when-let [parent (get signal :parent)]
@ -261,7 +277,9 @@
(spans_ parent-uid (spans_ parent-uid
(fn [old] (fn [old]
(or old (or old
(delay (start-span tracer parent-id parent-uid parent-inst root-span))))))))))) (delay
(start-span tracer (span-name parent-id)
parent-inst root-span)))))))))))
{this-uid :uid, this-end-inst :end-inst} signal] {this-uid :uid, this-end-inst :end-inst} signal]
@ -270,9 +288,10 @@
;; add `Event` (rather than child `Span`) to parent ;; add `Event` (rather than child `Span`) to parent
:if-let [this-is-event? (not this-end-inst)] :if-let [this-is-event? (not this-end-inst)]
(when-let [^Span parent-span ?parent-span] (when-let [^Span parent-span ?parent-span]
(let [{this-id :id, this-inst :inst} signal (let [{this-id :id, this-inst :inst} signal]
attrs (Attributes/of uid-attr-key (str this-uid))] (if-let [^Attributes attrs (span-attrs this-uid signal)]
(.addEvent parent-span (span-name this-id) attrs ^java.time.Instant this-inst)) (.addEvent parent-span (span-name this-id) attrs ^java.time.Instant this-inst)
(.addEvent parent-span (span-name this-id) ^java.time.Instant this-inst)))
(do parent-span)) (do parent-span))
:if-let :if-let
@ -287,17 +306,28 @@
(fn [old] (fn [old]
(or old (or old
(delay (delay
(start-span tracer this-id this-uid this-inst (start-span tracer (span-name this-id)
(or ?parent-span root-span))))))))))] this-inst (or ?parent-span root-span))))))))))]
(do (do
(if (utils/error-signal? signal) (if (utils/error-signal? signal)
(.setStatus this-span io.opentelemetry.api.trace.StatusCode/ERROR) (.setStatus this-span io.opentelemetry.api.trace.StatusCode/ERROR)
(.setStatus this-span io.opentelemetry.api.trace.StatusCode/OK)) (.setStatus this-span io.opentelemetry.api.trace.StatusCode/OK))
(when-let [^Attributes attrs (span-attrs this-uid signal)]
(.setAllAttributes this-span attrs))
;; Error stuff
(when-let [error (get signal :error)] (when-let [error (get signal :error)]
(when (instance? Throwable error) (when (instance? Throwable error)
(.recordException this-span error))) (if-let [attrs
(when-let [ex-data (ex-data error)]
(when-not (empty? ex-data)
(let [sb (Attributes/builder)]
(enc/run-kv! (fn [k v] (put-attr! sb (attr-name k) v)) ex-data)
(.build sb))))]
(.recordException this-span error attrs)
(.recordException this-span error))))
;; (.end this-span this-end-inst) ; Ready for `SpanExporter` ;; (.end this-span this-end-inst) ; Ready for `SpanExporter`
(end-buffer_ (fn [old] (conj old [this-uid this-end-inst]))) (end-buffer_ (fn [old] (conj old [this-uid this-end-inst])))