From d0a15bac6b874ee1ab6d5dfefa84312006bf43ab Mon Sep 17 00:00:00 2001 From: Peter Taoussanis Date: Tue, 23 Apr 2024 17:28:44 +0200 Subject: [PATCH] [mod] Don't auto add OpenTelemetry handler Adding this manually is easy, and it's probably better to ask users to do this explicitly since auto config won't always be successful. --- src/taoensso/telemere.cljc | 3 +-- src/taoensso/telemere/handlers/open_telemetry.clj | 5 ----- wiki/1-Getting-started.md | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/taoensso/telemere.cljc b/src/taoensso/telemere.cljc index 94fe2cc..dab6c8d 100644 --- a/src/taoensso/telemere.cljc +++ b/src/taoensso/telemere.cljc @@ -422,8 +422,7 @@ (add-handler! :default/console (handler:console))) #?(:clj (enc/catching (require '[taoensso.telemere.tools-logging]))) - #?(:clj (enc/catching (require '[taoensso.telemere.slf4j]))) - #?(:clj (enc/catching (require '[taoensso.telemere.handlers.open-telemetry])))) + #?(:clj (enc/catching (require '[taoensso.telemere.slf4j])))) ;;;; diff --git a/src/taoensso/telemere/handlers/open_telemetry.clj b/src/taoensso/telemere/handlers/open_telemetry.clj index 4c00da0..7ce19b6 100644 --- a/src/taoensso/telemere/handlers/open_telemetry.clj +++ b/src/taoensso/telemere/handlers/open_telemetry.clj @@ -219,9 +219,4 @@ (.setBody msg) (.setAllAttributes attrs))))))))) -;;;; -(impl/on-init - (when impl/auto-handlers? - (when-let [handler (enc/catching (handler:open-telemetry-logger))] - (tel/add-handler! :default/open-telemetry-logger handler)))) diff --git a/wiki/1-Getting-started.md b/wiki/1-Getting-started.md index 6467888..1d3ca3d 100644 --- a/wiki/1-Getting-started.md +++ b/wiki/1-Getting-started.md @@ -99,7 +99,6 @@ See section [3-Config](./3-Config) for customization. | -------- | --------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------- | | Clj | Always | [Console handler](https://cljdoc.org/d/com.taoensso/telemere/CURRENT/api/taoensso.telemere#handler:console) that prints signals to `*out*` or `*err*`. | | Cljs | Always | [Console handler](https://cljdoc.org/d/com.taoensso/telemere/CURRENT/api/taoensso.telemere#handler:console) that prints signals to the **browser console**. | -| Clj      | [OpenTelemetry API](https://mvnrepository.com/artifact/io.opentelemetry/opentelemetry-api) present | [OpenTelemetry handler](https://cljdoc.org/d/com.taoensso/telemere/CURRENT/api/taoensso.telemere#handler:open-telemetry-logger) that emits signals as log records to a configured [`LoggerProvider`](https://opentelemetry.io/docs/specs/otel/logs/sdk/#loggerprovider). | **Default signal intakes**: