luciano/terraform-aws-rds-proxy
1
0
Fork 0
mirror of https://github.com/terraform-aws-modules/terraform-aws-rds-proxy.git synced 2025-12-16 16:01:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Disable endpoint creation when setting create_proxy = false (#12)

Browse source 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
This commit is contained in:
Gavin Williams 2022-08-10 19:34:48 +01:00 committed by GitHub
parent 8c1720cee3
commit 26724abef9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.pre-commit-config.yaml
View file

@ -1,6 +1,6 @@
repos: repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform - repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.68.1 rev: v1.74.1
hooks: hooks:
- id: terraform_fmt - id: terraform_fmt
- id: terraform_validate - id: terraform_validate
@ -23,7 +23,7 @@ repos:
- '--args=--only=terraform_standard_module_structure' - '--args=--only=terraform_standard_module_structure'
- '--args=--only=terraform_workspace_remote' - '--args=--only=terraform_workspace_remote'
- repo: https://github.com/pre-commit/pre-commit-hooks - repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.2.0 rev: v4.3.0
hooks: hooks:
- id: check-merge-conflict - id: check-merge-conflict
- id: end-of-file-fixer - id: end-of-file-fixer

2
examples/mysql_iam_cluster/main.tf
View file

@ -47,7 +47,7 @@ module "rds_proxy" {
} }
secrets = { secrets = {
"${local.db_username}" = { (local.db_username) = {
description = aws_secretsmanager_secret.superuser.description description = aws_secretsmanager_secret.superuser.description
arn = aws_secretsmanager_secret.superuser.arn arn = aws_secretsmanager_secret.superuser.arn
kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id

2
examples/mysql_iam_instance/main.tf
View file

@ -47,7 +47,7 @@ module "rds_proxy" {
} }
secrets = { secrets = {
"${local.db_username}" = { (local.db_username) = {
description = aws_secretsmanager_secret.superuser.description description = aws_secretsmanager_secret.superuser.description
arn = aws_secretsmanager_secret.superuser.arn arn = aws_secretsmanager_secret.superuser.arn
kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id

2
examples/postgresql_iam_cluster/main.tf
View file

@ -47,7 +47,7 @@ module "rds_proxy" {
} }
secrets = { secrets = {
"${local.db_username}" = { (local.db_username) = {
description = aws_secretsmanager_secret.superuser.description description = aws_secretsmanager_secret.superuser.description
arn = aws_secretsmanager_secret.superuser.arn arn = aws_secretsmanager_secret.superuser.arn
kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id

2
examples/postgresql_iam_instance/main.tf
View file

@ -47,7 +47,7 @@ module "rds_proxy" {
} }
secrets = { secrets = {
"${local.db_username}" = { (local.db_username) = {
description = aws_secretsmanager_secret.superuser.description description = aws_secretsmanager_secret.superuser.description
arn = aws_secretsmanager_secret.superuser.arn arn = aws_secretsmanager_secret.superuser.arn
kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id

2
main.tf
View file

@ -68,7 +68,7 @@ resource "aws_db_proxy_target" "db_cluster" {
} }
resource "aws_db_proxy_endpoint" "this" { resource "aws_db_proxy_endpoint" "this" {
for_each = var.db_proxy_endpoints for_each = { for k, v in var.db_proxy_endpoints : k => v if var.create_proxy }
db_proxy_name = aws_db_proxy.this[0].name db_proxy_name = aws_db_proxy.this[0].name
db_proxy_endpoint_name = each.value.name db_proxy_endpoint_name = each.value.name