From b4d40ddfe17226251828286730ed26a264c6a6c0 Mon Sep 17 00:00:00 2001 From: Anton Kolesnikov Date: Fri, 30 Sep 2022 19:32:56 +0200 Subject: [PATCH] Fix DynamoDB checkpointer scan error handling Signed-off-by: Anton Kolesnikov --- clientlibrary/checkpoint/dynamodb-checkpointer.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/clientlibrary/checkpoint/dynamodb-checkpointer.go b/clientlibrary/checkpoint/dynamodb-checkpointer.go index f64e630..b45deaf 100644 --- a/clientlibrary/checkpoint/dynamodb-checkpointer.go +++ b/clientlibrary/checkpoint/dynamodb-checkpointer.go @@ -441,6 +441,11 @@ func (checkpointer *DynamoCheckpoint) syncLeases(shardStatus map[string]*par.Sha } scanOutput, err := checkpointer.svc.Scan(context.TODO(), input) + if err != nil { + log.Debugf("Error performing SyncLeases. Error: %+v ", err) + return err + } + results := scanOutput.Items for _, result := range results { shardId, foundShardId := result[LeaseKeyKey] @@ -456,10 +461,6 @@ func (checkpointer *DynamoCheckpoint) syncLeases(shardStatus map[string]*par.Sha } } - if err != nil { - log.Debugf("Error performing SyncLeases. Error: %+v ", err) - return err - } log.Debugf("Lease sync completed. Next lease sync will occur in %s", time.Duration(checkpointer.kclConfig.LeaseSyncingTimeIntervalMillis)*time.Millisecond) return nil }