luciano/vmware-go-kcl-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix the broken integrationt test (#48)

Browse source 
The https://github.com/vmware/vmware-go-kcl/pull/47 move zap
into its own packge but it also breaks the integration test.
This change is to fix integ test by correcting its package
reference.

Signed-off-by: Tao Jiang <taoj@vmware.com>
This commit is contained in:
Tao Jiang 2019-11-04 11:39:50 -06:00
parent 8a8f9e6339
commit d6369e48c2
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/logger_test.go
View file

@ -28,6 +28,7 @@ import (
"testing" "testing"
"github.com/vmware/vmware-go-kcl/logger" "github.com/vmware/vmware-go-kcl/logger"
zaplogger "github.com/vmware/vmware-go-kcl/logger/zap"
) )
func TestZapLoggerWithConfig(t *testing.T) { func TestZapLoggerWithConfig(t *testing.T) {
@ -41,7 +42,7 @@ func TestZapLoggerWithConfig(t *testing.T) {
Filename: "log.log", Filename: "log.log",
} }
log := logger.NewZapLoggerWithConfig(config) log := zaplogger.NewZapLoggerWithConfig(config)
contextLogger := log.WithFields(logger.Fields{"key1": "value1"}) contextLogger := log.WithFields(logger.Fields{"key1": "value1"})
contextLogger.Debugf("Starting with zap") contextLogger.Debugf("Starting with zap")
@ -52,7 +53,7 @@ func TestZapLogger(t *testing.T) {
zapLogger, err := zap.NewProduction() zapLogger, err := zap.NewProduction()
assert.Nil(t, err) assert.Nil(t, err)
log := logger.NewZapLogger(zapLogger.Sugar()) log := zaplogger.NewZapLogger(zapLogger.Sugar())
contextLogger := log.WithFields(logger.Fields{"key1": "value1"}) contextLogger := log.WithFields(logger.Fields{"key1": "value1"})
contextLogger.Debugf("Starting with zap") contextLogger.Debugf("Starting with zap")

5
test/worker_test.go
View file

@ -38,6 +38,7 @@ import (
"github.com/vmware/vmware-go-kcl/clientlibrary/utils" "github.com/vmware/vmware-go-kcl/clientlibrary/utils"
wk "github.com/vmware/vmware-go-kcl/clientlibrary/worker" wk "github.com/vmware/vmware-go-kcl/clientlibrary/worker"
"github.com/vmware/vmware-go-kcl/logger" "github.com/vmware/vmware-go-kcl/logger"
zaplogger "github.com/vmware/vmware-go-kcl/logger/zap"
) )
const ( const (
@ -109,7 +110,7 @@ func TestWorkerWithSigInt(t *testing.T) {
// At miminal. use standard zap logger // At miminal. use standard zap logger
//zapLogger, err := zap.NewProduction() //zapLogger, err := zap.NewProduction()
//assert.Nil(t, err) //assert.Nil(t, err)
//log := logger.NewZapLogger(zapLogger.Sugar()) //log := zaplogger.NewZapLogger(zapLogger.Sugar())
// //
// In order to have precise control over logging. Use logger with config. // In order to have precise control over logging. Use logger with config.
config := logger.Configuration{ config := logger.Configuration{
@ -122,7 +123,7 @@ func TestWorkerWithSigInt(t *testing.T) {
Filename: "log.log", Filename: "log.log",
} }
// use zap logger // use zap logger
log := logger.NewZapLoggerWithConfig(config) log := zaplogger.NewZapLoggerWithConfig(config)
kclConfig := cfg.NewKinesisClientLibConfig("appName", streamName, regionName, workerID). kclConfig := cfg.NewKinesisClientLibConfig("appName", streamName, regionName, workerID).
WithInitialPositionInStream(cfg.LATEST). WithInitialPositionInStream(cfg.LATEST).