luciano/vmware-go-kcl-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Re-org code for adding jittered delay for syncShard (#63)

Browse source 
Minor update for the previous commit by removing duplicated code.
No functional change.

Signed-off-by: Tao Jiang <taoj@vmware.com>
This commit is contained in:
Tao Jiang 2019-11-29 14:27:05 -06:00
parent 43a936cab3
commit df60778d89
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
clientlibrary/worker/worker.go
View file

@ -239,12 +239,15 @@ func (w *Worker) eventLoop() {
log := w.kclConfig.Logger log := w.kclConfig.Logger
for { for {
// Add [-50%, +50%] random jitter to ShardSyncIntervalMillis. When multiple workers
// starts at the same time, this decreases the probability of them calling
// kinesis.DescribeStream at the same time, and hit the hard-limit on aws API calls.
// On average the period remains the same so that doesn't affect behavior.
shardSyncSleep := w.kclConfig.ShardSyncIntervalMillis/2 + w.rng.Intn(int(w.kclConfig.ShardSyncIntervalMillis))
err := w.syncShard() err := w.syncShard()
if err != nil { if err != nil {
log.Errorf("Error getting Kinesis shards: %+v", err) log.Errorf("Error syncing shards: %+v, Retrying in %d ms...", err, shardSyncSleep)
// Add [-50%, +50%] random jitter to ShardSyncIntervalMillis in case of error.
shardSyncSleep := w.kclConfig.ShardSyncIntervalMillis/2 + w.rng.Intn(int(w.kclConfig.ShardSyncIntervalMillis))
time.Sleep(time.Duration(shardSyncSleep) * time.Millisecond) time.Sleep(time.Duration(shardSyncSleep) * time.Millisecond)
continue continue
} }
@ -313,11 +316,7 @@ func (w *Worker) eventLoop() {
log.Infof("Shutting down...") log.Infof("Shutting down...")
return return
default: default:
// Add [-50%, +50%] random jitter to ShardSyncIntervalMillis. When multiple workers log.Debugf("Trying to sync shards in %d ms...", shardSyncSleep)
// starts at the same time, this decreases the probability of them calling
// kinesis.DescribeStream at the same time, and hit the hard-limit on aws API calls.
// On average the period remains the same so that doesn't affect behavior.
shardSyncSleep := w.kclConfig.ShardSyncIntervalMillis/2 + w.rng.Intn(int(w.kclConfig.ShardSyncIntervalMillis))
time.Sleep(time.Duration(shardSyncSleep) * time.Millisecond) time.Sleep(time.Duration(shardSyncSleep) * time.Millisecond)
} }
} }