luciano/vmware-go-kcl-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix data race during checkpointing (#82)

Browse source 
Make sure shard is locked during checkpointing.

Signed-off-by: Tao Jiang <taoj@vmware.com>
This commit is contained in:
Tao Jiang 2020-12-18 22:11:10 -06:00
parent 499e9cf1be
commit f1982602ff
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clientlibrary/worker/record-processor-checkpointer.go
View file

@ -65,6 +65,7 @@ func (pc *PreparedCheckpointer) Checkpoint() error {
func (rc *RecordProcessorCheckpointer) Checkpoint(sequenceNumber *string) error { func (rc *RecordProcessorCheckpointer) Checkpoint(sequenceNumber *string) error {
rc.shard.Mux.Lock() rc.shard.Mux.Lock()
defer rc.shard.Mux.Unlock()
// checkpoint the last sequence of a closed shard // checkpoint the last sequence of a closed shard
if sequenceNumber == nil { if sequenceNumber == nil {
@ -73,7 +74,6 @@ func (rc *RecordProcessorCheckpointer) Checkpoint(sequenceNumber *string) error
rc.shard.Checkpoint = aws.StringValue(sequenceNumber) rc.shard.Checkpoint = aws.StringValue(sequenceNumber)
} }
rc.shard.Mux.Unlock()
return rc.checkpoint.CheckpointSequence(rc.shard) return rc.checkpoint.CheckpointSequence(rc.shard)
} }