luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleaning up LeaseManagementConfig (#366)

Browse source 
* Cleaning up LeaseManagementConfig:

* Removing unused metrics factory variable from LeaseManagementConfig.

* Revert "Cleaning up LeaseManagementConfig:"

This reverts commit b16ba37966.

* Deprecating metrics factory in LeaseManagementConfig

* Marking metrics factory in LeaseManagementConfig for deprecation
This commit is contained in:
Sahil Palvia 2018-08-15 11:14:15 -07:00 committed by GitHub
parent 6973152f60
commit 205cf051f3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java
View file

@ -170,11 +170,39 @@ public class LeaseManagementConfig {
private long listShardsCacheAllowedAgeInSeconds = 30; private long listShardsCacheAllowedAgeInSeconds = 30;
private int cacheMissWarningModulus = 250; private int cacheMissWarningModulus = 250;
/**
*
*/
private MetricsFactory metricsFactory = new NullMetricsFactory(); private MetricsFactory metricsFactory = new NullMetricsFactory();
/**
* Returns the metrics factory.
*
* <p>
* NOTE: This method is deprecated and will be removed in a future release. This metrics factory is not being used
* in the KCL.
* </p>
*
* @return
*/
@Deprecated
public MetricsFactory metricsFactory() {
return metricsFactory;
}
/**
* Sets the metrics factory.
*
* <p>
* NOTE: This method is deprecated and will be removed in a future release. This metrics factory is not being used
* in the KCL.
* </p>
*
* @param metricsFactory
*/
@Deprecated
public LeaseManagementConfig metricsFactory(final MetricsFactory metricsFactory) {
this.metricsFactory = metricsFactory;
return this;
}
/** /**
* The {@link ExecutorService} to be used by {@link ShardSyncTaskManager}. * The {@link ExecutorService} to be used by {@link ShardSyncTaskManager}.
* *