luciano/amazon-kinesis-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use StringUtils.join instead of manually building ids string

Browse source
This commit is contained in:
Mike Watters 2017-12-12 13:16:01 -07:00
parent 044fb3a652
commit ee54e30b84
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/java/com/amazonaws/services/kinesis/clientlibrary/lib/worker/ShardSyncer.java
View file

@ -28,6 +28,7 @@ import java.util.Set;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.apache.commons.lang.StringUtils;
import com.amazonaws.services.kinesis.clientlibrary.exceptions.internal.KinesisClientLibIOException; import com.amazonaws.services.kinesis.clientlibrary.exceptions.internal.KinesisClientLibIOException;
import com.amazonaws.services.kinesis.clientlibrary.proxies.IKinesisProxy; import com.amazonaws.services.kinesis.clientlibrary.proxies.IKinesisProxy;
@ -167,10 +168,7 @@ class ShardSyncer {
private static void assertAllParentShardsAreClosed(Set<String> inconsistentShardIds) private static void assertAllParentShardsAreClosed(Set<String> inconsistentShardIds)
throws KinesisClientLibIOException { throws KinesisClientLibIOException {
if (!inconsistentShardIds.isEmpty()) { if (!inconsistentShardIds.isEmpty()) {
String ids = ""; String ids = StringUtils.join(inconsistentShardIds, ' ');
for (String id : inconsistentShardIds) {
ids += " " + id;
}
throw new KinesisClientLibIOException(String.format("%d open child shards (%s) are inconsistent. " throw new KinesisClientLibIOException(String.format("%d open child shards (%s) are inconsistent. "
+ "This can happen due to a race condition between describeStream and a reshard operation.", + "This can happen due to a race condition between describeStream and a reshard operation.",
inconsistentShardIds.size(), ids)); inconsistentShardIds.size(), ids));