luciano/d2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ignore when no params

Browse source
This commit is contained in:
Alexander Wang 2023-05-04 20:29:53 -07:00
parent 742389f8df
commit db21d350c5
No known key found for this signature in database
GPG key ID: D89FA31966BDBECE
4 changed files with 2 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
d2oracle/edit.go
View file

@ -110,7 +110,7 @@ func ReconnectEdge(g *d2graph.Graph, edgeKey string, srcKey, dstKey *string) (_
}
if srcKey == nil && dstKey == nil {
return nil, errors.New("must provide at least one new endpoint")
return g, nil
}
var src *d2graph.Object
@ -1893,7 +1893,7 @@ func ReconnectEdgeIDDeltas(g *d2graph.Graph, edgeKey string, srcKey, dstKey *str
}
if srcKey == nil && dstKey == nil {
return nil, errors.New("must provide at least one new endpoint")
return nil, nil
}
newSrc := edge.Src

15
d2oracle/edit_test.go
View file

@ -1768,21 +1768,6 @@ x
newDst: "x",
expErr: "newDst not found",
},
{
name: "missing_params",
text: `a -> b
`,
edgeKey: `(a -> b)[0]`,
expErr: "must provide at least one new endpoint",
},
{
name: "bad_params",
text: `a -> b
`,
edgeKey: `(a -> b)[0]`,
newDst: "b",
expErr: "must provide at least one new endpoint",
},
}
for _, tc := range testCases {

4
testdata/d2oracle/TestReconnectEdge/bad_params.exp.json generated vendored
View file

@ -1,4 +0,0 @@
{
"graph": null,
"err": "&errors.errorString{s:\"must provide at least one new endpoint\"}"
}

4
testdata/d2oracle/TestReconnectEdge/missing_params.exp.json generated vendored
View file

@ -1,4 +0,0 @@
{
"graph": null,
"err": "&errors.errorString{s:\"must provide at least one new endpoint\"}"
}