ignore when no params
This commit is contained in:
parent
742389f8df
commit
db21d350c5
4 changed files with 2 additions and 25 deletions
|
|
@ -110,7 +110,7 @@ func ReconnectEdge(g *d2graph.Graph, edgeKey string, srcKey, dstKey *string) (_
|
||||||
}
|
}
|
||||||
|
|
||||||
if srcKey == nil && dstKey == nil {
|
if srcKey == nil && dstKey == nil {
|
||||||
return nil, errors.New("must provide at least one new endpoint")
|
return g, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
var src *d2graph.Object
|
var src *d2graph.Object
|
||||||
|
|
@ -1893,7 +1893,7 @@ func ReconnectEdgeIDDeltas(g *d2graph.Graph, edgeKey string, srcKey, dstKey *str
|
||||||
}
|
}
|
||||||
|
|
||||||
if srcKey == nil && dstKey == nil {
|
if srcKey == nil && dstKey == nil {
|
||||||
return nil, errors.New("must provide at least one new endpoint")
|
return nil, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
newSrc := edge.Src
|
newSrc := edge.Src
|
||||||
|
|
|
||||||
|
|
@ -1768,21 +1768,6 @@ x
|
||||||
newDst: "x",
|
newDst: "x",
|
||||||
expErr: "newDst not found",
|
expErr: "newDst not found",
|
||||||
},
|
},
|
||||||
{
|
|
||||||
name: "missing_params",
|
|
||||||
text: `a -> b
|
|
||||||
`,
|
|
||||||
edgeKey: `(a -> b)[0]`,
|
|
||||||
expErr: "must provide at least one new endpoint",
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: "bad_params",
|
|
||||||
text: `a -> b
|
|
||||||
`,
|
|
||||||
edgeKey: `(a -> b)[0]`,
|
|
||||||
newDst: "b",
|
|
||||||
expErr: "must provide at least one new endpoint",
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range testCases {
|
for _, tc := range testCases {
|
||||||
|
|
|
||||||
4
testdata/d2oracle/TestReconnectEdge/bad_params.exp.json
generated
vendored
4
testdata/d2oracle/TestReconnectEdge/bad_params.exp.json
generated
vendored
|
|
@ -1,4 +0,0 @@
|
||||||
{
|
|
||||||
"graph": null,
|
|
||||||
"err": "&errors.errorString{s:\"must provide at least one new endpoint\"}"
|
|
||||||
}
|
|
||||||
4
testdata/d2oracle/TestReconnectEdge/missing_params.exp.json
generated
vendored
4
testdata/d2oracle/TestReconnectEdge/missing_params.exp.json
generated
vendored
|
|
@ -1,4 +0,0 @@
|
||||||
{
|
|
||||||
"graph": null,
|
|
||||||
"err": "&errors.errorString{s:\"must provide at least one new endpoint\"}"
|
|
||||||
}
|
|
||||||
Loading…
Reference in a new issue